linux-kernel - Re: v4l & compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y783jdjo.fsf@basil.nowhere.org>
Date:	28 Mar 2008 12:25:31 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Linux and Kernel Video <video4linux-list@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: v4l & compat_ioctl

Jiri Slaby <jirislaby@...il.com> writes:

> wouldn't make sense to add v4l ioctls to ioctl_start
> (fs/compat_ioctl.c) table to allow i386 stuff such as skype to run
> video on x86_64?

Don't make it a question.

In general any ioctl in any driver runnable on any 64bit
architecture that has a 32bit compat layer should have compat 
support. Not having it is a bug.

However the new standard way to do this is to not 
add new stuff into compat_ioctl.c, but define ->compat_ioctl
entry points in the low level drivers (and ideally converted
them to ->unlocked_ioctl too while you're at it)

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/