linux-kernel - Re: agpgart: when telling user you'll corrupt his data, at least do it at KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080328113508.GP29105@one.firstfloor.org>
Date:	Fri, 28 Mar 2008 12:35:08 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Pavel Machek <pavel@....cz>
Cc:	Andi Kleen <andi@...stfloor.org>, Ingo Molnar <mingo@...e.hu>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: agpgart: when telling user you'll corrupt his data, at least do it at KERN_CRIT

On Fri, Mar 28, 2008 at 12:25:07PM +0100, Pavel Machek wrote:
> 
> IOMMU off means very bad stuff may happen, like data corruption on

Actually swiotlb takes over then in this case. The printk really
predates the introduction of swiotlb and could be actually removed.
That is why swiotlb is always SELECTed for gart too.

> your hard drives. At least tells users this is serious...

No there shouldn't be any data corruption with the default options.

Also especially hard disk drivers are expected (and generally do)
check the dma_map_sg() etc. return values and bail out if the IOMMU
fails e.g. due to overflow.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/