linux-kernel - Re: [PATCH] don't suspend/resume 8xx chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080328144003.GF4404@ucw.cz>
Date:	Fri, 28 Mar 2008 15:40:04 +0100
From:	Pavel Machek <pavel@....cz>
To:	Jesse Barnes <jesse.barnes@...el.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Dave Airlie <airlied@...ux.ie>
Subject: Re: [PATCH] don't suspend/resume 8xx chips

On Wed 2008-03-26 16:28:12, Jesse Barnes wrote:
> Recent testing has turned up some bugs in the new Intel suspend/resume code 
> for old, 8xx chipsets.  So for 2.6.25 it probably makes sense to apply this 
> patch, which should prevent the new code from getting called on those 
> chipsets.  We should have this fixed soon, but not in time for 2.6.25 
> unfortunately.  Note that this patch (along with the suspend/resume code in 
> general) could use more testing.
> 
> Signed-off-by:  Jesse Barnes <jesse.barnes@...el.com>
> 
> diff --git a/drivers/char/drm/i915_dma.c b/drivers/char/drm/i915_dma.c
> index e9d6663..6964a28 100644
> --- a/drivers/char/drm/i915_dma.c
> +++ b/drivers/char/drm/i915_dma.c
> @@ -762,6 +762,11 @@ int i915_driver_load(struct drm_device *dev, unsigned 
> long
>         unsigned long base, size;
>         int ret = 0, mmio_bar = IS_I9XX(dev) ? 0 : 1;
> 
> +       if (!IS_I9XX(dev)) {
> +               dev->driver->suspend = NULL;
> +               dev->driver->resume = NULL;
> +       }
> +

Are you sure your driver needs no state saving?

Maybe register suspend that printks, returns error?
							Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/