linux-kernel - Re: [patch] pci: revert "PCI: remove transparent bridge sizing"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080328204616.GB6233@us.ibm.com>
Date:	Fri, 28 Mar 2008 13:46:16 -0700
From:	Gary Hade <garyhade@...ibm.com>
To:	Gary Hade <garyhade@...ibm.com>
Cc:	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, Thomas Meyer <thomas@...3r.de>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	LKML <linux-kernel@...r.kernel.org>,
	Adrian Bunk <bunk@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Natalie Protasevich <protasnb@...il.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	pm@...ian.org
Subject: Re: [patch] pci: revert "PCI: remove transparent bridge sizing"

On Fri, Mar 28, 2008 at 12:24:02PM -0700, Gary Hade wrote:
> On Fri, Mar 28, 2008 at 01:18:51AM +0300, Ivan Kokshaysky wrote:
> > On Thu, Mar 27, 2008 at 10:12:10AM -0700, Linus Torvalds wrote:
> > > Actually, before we go any further, there might be a less intrusive 
> > > alternative: add just a couple of flags to the resource flags field (we 
> > > still have something like 8 unused bits on 32-bit), and use those to 
> > > implement a generic "resource_alignment()" routine.
> > > 
> > > Two flags would do it:
> > > 
> > >  - IORESOURCE_SIZEALIGN: size indicates alignment (regular PCI device 
> > >    resources)
> > > 
> > >  - IORESOURCE_STARTALIGN: start field is alignment (PCI bus resources 
> > >    during probing)
> > 
> > Sounds good to me. So here we go (completely untested, just for review).
> 
> Ivan, After adding a resource_alignment() prototype to
                 < snip >
> Will now try on one of our servers that I am the most concerned
> about.

Just tried it on an IBM x3850.  No obvious problems or unexpected
messages spotted during/following boot or during/following hotplug
of PCI-X and PCIe cards.

Gary

-- 
Gary Hade
System x Enablement
IBM Linux Technology Center
503-578-4503  IBM T/L: 775-4503
garyhade@...ibm.com
http://www.ibm.com/linux/ltc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/