linux-kernel - Re: Comma at end of enum lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47EE7A66.30905@zytor.com>
Date:	Sat, 29 Mar 2008 10:20:38 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Jacek Luczak <difrost.kernel@...il.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: Comma at end of enum lists

Jacek Luczak wrote:
> Hi All,
> 
> I've found that in many enum lists, there's a comma at the end, e.g. 
> (arch/x86/kernel/early_printk.c):
> 
> enum {
>         MAGIC1 = 0xBACCD00A,
>         MAGIC2 = 0xCA110000,
>         XOPEN = 5,
>         XWRITE = 4,
> };
> 
> Just out of curiosity, is there any particular reason here (no word in 
> CodingStyle about that).
> 

Yes, it's so you can add a line without affecting the line before it, 
making a one-line patch into a two-line patch that's more likely to 
conflict.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/