linux-kernel - Re: Comma at end of enum lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 29 Mar 2008 18:22:56 +0100
From:	Jacek Luczak <difrost.kernel@...il.com>
To:	Mikael Pettersson <mikpe@...uu.se>
CC:	linux-kernel@...r.kernel.org
Subject: Re: Comma at end of enum lists

Mikael Pettersson pisze:
> Jacek Luczak writes:
>  > Hi All,
>  > 
>  > I've found that in many enum lists, there's a comma at the end, e.g. 
>  > (arch/x86/kernel/early_printk.c):
>  > 
>  > enum {
>  >          MAGIC1 = 0xBACCD00A,
>  >          MAGIC2 = 0xCA110000,
>  >          XOPEN = 5,
>  >          XWRITE = 4,
>  > };
>  > 
>  > Just out of curiosity, is there any particular reason here (no word in 
>  > CodingStyle about that).
> 
> Yes. This idiom allows you to add or remove items without
> changing adjacent lines.

Yep, that's obvious, one line less in diff after every enum change  :)

> In a language with strict a comma-as-separator rule you can
> get this benefit by placing the comma before new items rather
> than after existing items:
> 
> enum {	FOO
> 	,FIE
> 	,FUM
> };
> 
> but luckily C doesn't need this perversion.
> 

I was just curious, because it's not common schema (some miss extra comma).

Thanks,
	-Jacek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/