linux-kernel - Re: [PATCH] fix the broken annotations in fsldma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080329183828.GD9785@ZenIV.linux.org.uk>
Date:	Sat, 29 Mar 2008 18:38:28 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Josh Boyer <jwboyer@...il.com>
Cc:	Al Viro <viro@....linux.org.uk>, torvalds@...ux-foundation.org,
	wei.zhang@...escale.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix the broken annotations in fsldma

On Sat, Mar 29, 2008 at 09:02:02AM -0500, Josh Boyer wrote:
> On Sat, 2008-03-29 at 03:10 +0000, Al Viro wrote:
> > a) every bitwise declaration will give a unique type; use typedefs.
> > b) no need to bother with the stuff pointed to by iomem pointers, unless
> > it's accessed directly.  noderef will force us to use helpers anyway.

> Did you forget to do the s/u{32,64}/v{32,64}/ conversion for this
> struct, or am I just a moron?

See (b) above.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/