linux-kernel - RE: [PATCH] fix the broken annotations in fsldma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <78567AC4946EDC42B7DE978C350CD869EEBC96@zch01exm26.fsl.freescale.net>
Date:	Mon, 31 Mar 2008 10:12:58 +0800
From:	"Zhang Wei" <Wei.Zhang@...escale.com>
To:	"Al Viro" <viro@...IV.linux.org.uk>,
	"Josh Boyer" <jwboyer@...il.com>
Cc:	"Al Viro" <viro@....linux.org.uk>, <torvalds@...ux-foundation.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] fix the broken annotations in fsldma

Hi, 

> -----Original Message-----
> From: Al Viro [mailto:viro@....linux.org.uk] On Behalf Of Al Viro
> 
> On Sat, Mar 29, 2008 at 09:02:02AM -0500, Josh Boyer wrote:
> > On Sat, 2008-03-29 at 03:10 +0000, Al Viro wrote:
> > > a) every bitwise declaration will give a unique type; use 
> typedefs.
> > > b) no need to bother with the stuff pointed to by iomem 
> pointers, unless
> > > it's accessed directly.  noderef will force us to use 
> helpers anyway.
> 
> > Did you forget to do the s/u{32,64}/v{32,64}/ conversion for this
> > struct, or am I just a moron?
> 
> See (b) above.
> 

Do you mean if we do it with a known 'force' casting, we do not need the
compiler check's help?

Thanks!
Wei.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/