linux-kernel - Re: linux-next: Tree for March 29

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080331.002836.159833482.davem@davemloft.net>
Date:	Mon, 31 Mar 2008 00:28:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sfr@...b.auug.org.au
Cc:	haavard.skinnemoen@...el.com, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: linux-next: Tree for March 29

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Sun, 30 Mar 2008 13:55:02 +1100

> Hi Haavard,
> 
> On Sat, 29 Mar 2008 19:12:55 +0100 Haavard Skinnemoen <haavard.skinnemoen@...el.com> wrote:
> >
> > allnoconfig fails with
> > 
> > include/linux/netdevice.h:843: error: implicit declaration of function 'dev_net'
> > 
> > which seems to be because the definition of dev_net is inside #ifdef
> > CONFIG_NET, while next_net_device, which calls it, is not.
> 
> Thanks for tracking these down.

I've checked in the following to net-2.6.26 to fix this, thanks:

commit 3edf8fa5ccf10688a9280b5cbca8ed3947c42866
Author: David S. Miller <davem@...emloft.net>
Date:   Mon Mar 31 00:28:14 2008 -0700

    [NET]: Fix allnoconfig build on powerpc and avr32
    
    As reported by Haavard Skinnemoen and Stephen Rothwell:
    
    > allnoconfig fails with
    >
    > include/linux/netdevice.h:843: error: implicit declaration of function 'dev_net'
    >
    > which seems to be because the definition of dev_net is inside #ifdef
    > CONFIG_NET, while next_net_device, which calls it, is not.
    
    Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 8576ca9..993758f 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -827,6 +827,7 @@ struct packet_type {
 extern rwlock_t				dev_base_lock;		/* Device list lock */
 
 
+#ifdef CONFIG_NET
 #define for_each_netdev(net, d)		\
 		list_for_each_entry(d, &(net)->dev_base_head, dev_list)
 #define for_each_netdev_safe(net, d, n)	\
@@ -850,6 +851,7 @@ static inline struct net_device *first_net_device(struct net *net)
 	return list_empty(&net->dev_base_head) ? NULL :
 		net_device_entry(net->dev_base_head.next);
 }
+#endif
 
 extern int 			netdev_boot_setup_check(struct net_device *dev);
 extern unsigned long		netdev_boot_base(const char *prefix, int unit);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/