linux-kernel - Re: [PATCH 5/7] lxfb: add power management functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080331074002.GB5106@ucw.cz>
Date:	Mon, 31 Mar 2008 09:40:03 +0200
From:	Pavel Machek <pavel@....cz>
To:	Andres Salomon <dilinger@...ued.net>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, adaplas@...il.com,
	linux-kernel@...r.kernel.org,
	linux-fbdev-devel@...ts.sourceforge.net, info-linux@...de.amd.com,
	jordan.crouse@....com
Subject: Re: [PATCH 5/7] lxfb: add power management functionality

Hi!

> +static int lxfb_suspend(struct pci_dev *pdev, pm_message_t state)
> +{
> +	struct fb_info *info = pci_get_drvdata(pdev);
> +
> +	if (pdev->dev.power.power_state.event == state.event)
> +		return 0;

This should never trigger. See Doc*/feature-removal-sch*.


> +	/* there's no point in setting PCI states; we emulate PCI, so
> +	 * we don't end up getting power savings anyways */
> +
> +	pdev->dev.power.power_state = state;


And there's no point doing this.

> +	pdev->dev.power.power_state = PMSG_ON;

Or this.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/