linux-kernel - [PATCH linux-next] x86_32: fix VisualWS and Voyager kexec build failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080401104950.83b02073.randy.dunlap@oracle.com>
Date:	Tue, 1 Apr 2008 10:49:50 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	lkml <linux-kernel@...r.kernel.org>, ebiederm@...ssion.com
Cc:	mingo <mingo@...hat.com>, tglx <tglx@...utronix.de>,
	hpa <hpa@...or.com>, akpm <akpm@...ux-foundation.org>
Subject: [PATCH linux-next] x86_32: fix VisualWS and Voyager kexec build
 failures

From: Randy Dunlap <randy.dunlap@...cle.com>

cc: Eric Biederman <ebiederm@...ssion.com>

Both Visual WS and Voyager builds fail in almost the same way (in
linux-next) without this patch:

VOYAGER:
kernel/built-in.o: In function `crash_kexec':
(.text+0x28588): undefined reference to `machine_crash_shutdown'

VISWS:
kernel/built-in.o: In function `crash_kexec':
/next-20080401/kernel/kexec.c:1074: undefined reference to `machine_crash_shutdown'
make[1]: *** [.tmp_vmlinux1] Error 1

because arch/x86/kernel/reboot.c isn't built since CONFIG_X86_BIOS_REBOOT=n,
so machine_crash_shutdown() isn't available.

This patch does seem a small bit odd since the KEXEC help text says that
kexec is independent of the system firmware.

Eric, is there some other way that this should be handled?

Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
---
 arch/x86/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- next-20080401.orig/arch/x86/Kconfig
+++ next-20080401/arch/x86/Kconfig
@@ -1094,6 +1094,7 @@ source kernel/Kconfig.hz
 
 config KEXEC
 	bool "kexec system call"
+	depends on X86_64 || X86_BIOS_REBOOT
 	help
 	  kexec is a system call that implements the ability to shutdown your
 	  current kernel, and to start another kernel.  It is like a reboot
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/