linux-kernel - Re: [PATCH linux-next] x86_32: fix VisualWS and Voyager kexec build failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m17ifgrbtg.fsf@ebiederm.dsl.xmission.com>
Date:	Wed, 02 Apr 2008 00:49:15 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	lkml <linux-kernel@...r.kernel.org>, ebiederm@...ssion.com,
	mingo <mingo@...hat.com>, tglx <tglx@...utronix.de>,
	hpa <hpa@...or.com>, akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH linux-next] x86_32: fix VisualWS and Voyager kexec build failures

Randy Dunlap <randy.dunlap@...cle.com> writes:

> From: Randy Dunlap <randy.dunlap@...cle.com>
>
> cc: Eric Biederman <ebiederm@...ssion.com>
>
> Both Visual WS and Voyager builds fail in almost the same way (in
> linux-next) without this patch:
>
> VOYAGER:
> kernel/built-in.o: In function `crash_kexec':
> (.text+0x28588): undefined reference to `machine_crash_shutdown'
>
> VISWS:
> kernel/built-in.o: In function `crash_kexec':
> /next-20080401/kernel/kexec.c:1074: undefined reference to
> `machine_crash_shutdown'
> make[1]: *** [.tmp_vmlinux1] Error 1
>
> because arch/x86/kernel/reboot.c isn't built since CONFIG_X86_BIOS_REBOOT=n,
> so machine_crash_shutdown() isn't available.

Weird.  I haven't had a chance to update to the devel kernels lately.
And in the older kernel I have machine_crash_shutdown is in crash.c
and is indeed not dependent xyz.

I get the feeling someone refactored something and ran afoul of the
x86_32 weird subarchitecture stuff in their testing.

> This patch does seem a small bit odd since the KEXEC help text says that
> kexec is independent of the system firmware.

Yes.

> Eric, is there some other way that this should be handled?

Yes.  Move machine_crash_shutdown back into crash.c
Or find some other way to accomplish whatever cleanup was done,
so that we still compile.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/