linux-kernel - Re: [PATCH] ssb: Fix build for non-PCIhost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080402083343.02de39c0.randy.dunlap@oracle.com>
Date:	Wed, 2 Apr 2008 08:33:43 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Michael Buesch <mb@...sch.de>
Cc:	John Linville <linville@...driver.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	bcm43xx-dev@...ts.berlios.de, linux-wireless@...r.kernel.org
Subject: Re: [PATCH] ssb: Fix build for non-PCIhost

On Wed, 2 Apr 2008 17:03:26 +0200 Michael Buesch wrote:

> This fixes a build error when PCMCIA-host support is built,
> but PCI-host support is disabled.
> Hell, who on earth would use such a weird configuration. :D
> 
> drivers/built-in.o: In function `ssb_attr_sprom_store':
> (.text+0x1c4b79): undefined reference to `ssb_devices_freeze'
> drivers/built-in.o: In function `ssb_attr_sprom_store':
> (.text+0x1c4bb3): undefined reference to `ssb_devices_thaw'
> make[1]: *** [.tmp_vmlinux1] Error 1
> 
> Signed-off-by: Michael Buesch <mb@...sch.de>

Acked-by: Randy Dunlap <randy.dunlap@...cle.com>


> ---
> 
> John, please apply this to 2.6.26
> 
> 
> Index: wireless-testing/drivers/ssb/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/ssb/main.c	2008-03-21 21:41:31.000000000 +0100
> +++ wireless-testing/drivers/ssb/main.c	2008-04-02 16:50:16.000000000 +0200
> @@ -202,7 +202,7 @@ out:
>  	return err;
>  }
>  
> -#ifdef CONFIG_SSB_PCIHOST
> +#ifdef CONFIG_SSB_SPROM
>  int ssb_devices_freeze(struct ssb_bus *bus)
>  {
>  	struct ssb_device *dev;
> @@ -288,7 +288,7 @@ int ssb_devices_thaw(struct ssb_bus *bus
>  
>  	return 0;
>  }
> -#endif /* CONFIG_SSB_PCIHOST */
> +#endif /* CONFIG_SSB_SPROM */
>  
>  static void ssb_device_shutdown(struct device *dev)
>  {
> 
> 
> -- 

---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/