linux-kernel - Re: [PATCH 1/2] Keep track of original clocksource frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1207150717.6211.0.camel@jstultz-laptop>
Date:	Wed, 02 Apr 2008 08:38:37 -0700
From:	John Stultz <johnstul@...ibm.com>
To:	Roman Zippel <zippel@...ux-m68k.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/2] Keep track of original clocksource frequency


On Wed, 2008-04-02 at 13:20 +0200, Roman Zippel wrote:
> Hi,
> 
> On Tue, 18 Mar 2008, john stultz wrote:
> 
> > @@ -63,6 +64,7 @@ struct clocksource {
> >  	cycle_t (*read)(void);
> >  	cycle_t mask;
> >  	u32 mult;
> > +	s32 mult_orig;
> >  	u32 shift;
> >  	unsigned long flags;
> >  	cycle_t (*vread)(void);
> 
> This is wrong, with HZ=100 the jiffies clock multiplier suddenly becomes 
> negative and later the raw interval underflows.

Ah, thanks for catching that!

> 
> Signed-off-by: Roman Zippel <zippel@...ux-m68k.org>

Acked-by: John Stultz <johnstul@...ibm.com>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/