[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1207158176.23710.7.camel@nimitz.home.sr71.net>
Date: Wed, 02 Apr 2008 10:42:56 -0700
From: Dave Hansen <dave@...ux.vnet.ibm.com>
To: Gerald Schaefer <gerald.schaefer@...ibm.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
schwidefsky@...ibm.com, Ingo Molnar <mingo@...e.hu>,
"David S. Miller" <davem@...emloft.net>,
Tony Luck <tony.luck@...el.com>,
Paul Mackerras <paulus@...ba.org>,
Thomas Gleixner <tglx@...utronix.de>,
Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [PATCH 1/3] hugetlbfs: architecture header cleanup
On Wed, 2008-04-02 at 16:26 +0200, Gerald Schaefer wrote:
>
> include/asm-ia64/hugetlb.h | 21 +++++++++++++++++++
> include/asm-ia64/page.h | 6 -----
> include/asm-powerpc/hugetlb.h | 35 +++++++++++++++++++++++++++++++
> include/asm-powerpc/page_64.h | 7 ------
> include/asm-sh/hugetlb.h | 28 +++++++++++++++++++++++++
> include/asm-sparc64/hugetlb.h | 30 +++++++++++++++++++++++++++
> include/asm-sparc64/page.h | 2 -
> include/asm-x86/hugetlb.h | 28 +++++++++++++++++++++++++
> include/linux/hugetlb.h | 46 ------------------------------------------
The way I read this, you took some arch-independent bits, like
prepare_hugepage_range(), and copied them to several architectures. How
is this a cleanup? Can they really not share common code?
-- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists