linux-kernel - Re: [PATCH 1/3] hugetlbfs: architecture header cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080402190713.GB16164@osiris.boeblingen.de.ibm.com>
Date:	Wed, 2 Apr 2008 21:07:13 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Dave Hansen <dave@...ux.vnet.ibm.com>
Cc:	Gerald Schaefer <gerald.schaefer@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
	schwidefsky@...ibm.com, Ingo Molnar <mingo@...e.hu>,
	"David S. Miller" <davem@...emloft.net>,
	Tony Luck <tony.luck@...el.com>,
	Paul Mackerras <paulus@...ba.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [PATCH 1/3] hugetlbfs: architecture header cleanup

On Wed, Apr 02, 2008 at 10:42:56AM -0700, Dave Hansen wrote:
> 
> On Wed, 2008-04-02 at 16:26 +0200, Gerald Schaefer wrote:
> > 
> >  include/asm-ia64/hugetlb.h    |   21 +++++++++++++++++++
> >  include/asm-ia64/page.h       |    6 -----
> >  include/asm-powerpc/hugetlb.h |   35 +++++++++++++++++++++++++++++++
> >  include/asm-powerpc/page_64.h |    7 ------
> >  include/asm-sh/hugetlb.h      |   28 +++++++++++++++++++++++++
> >  include/asm-sparc64/hugetlb.h |   30 +++++++++++++++++++++++++++
> >  include/asm-sparc64/page.h    |    2 -
> >  include/asm-x86/hugetlb.h     |   28 +++++++++++++++++++++++++
> >  include/linux/hugetlb.h       |   46 ------------------------------------------
> 
> The way I read this, you took some arch-independent bits, like
> prepare_hugepage_range(), and copied them to several architectures.  How
> is this a cleanup?  Can they really not share common code? 

This question has been raised before. See: http://lkml.org/lkml/2008/3/28/267 .
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/