linux-kernel - Re: [RFC 18/22] sh: Use generic show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 03 Apr 2008 15:08:39 +0200
From:	Johannes Weiner <hannes@...urebad.de>
To:	Paul Mundt <lethal@...ux-sh.org>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org, mingo@...e.hu,
	davem@...emloft.net, hskinnemoen@...el.com, cooloney@...nel.org,
	starvik@...s.com, dhowells@...hat.com, ysato@...rs.sf.net,
	takata@...ux-m32r.org, geert@...ux-m68k.org, ralf@...ux-mips.org,
	kyle@...isc-linux.org, paulus@...ba.org, schwidefsky@...ibm.com,
	jdike@...toit.com, miles@....org, chris@...kel.net,
	rmk@....linux.org.uk, tony.luck@...el.com
Subject: Re: [RFC 18/22] sh: Use generic show_mem()

Hi Paul,

Paul Mundt <lethal@...ux-sh.org> writes:

> On Wed, Apr 02, 2008 at 10:40:24PM +0200, Johannes Weiner wrote:
>> -	printk(KERN_INFO "Total of %ld pages in page table cache\n",
>> -	       quicklist_total_size());
>> -}
>> -
>
> NACK. The quicklists are also absent from the generic implementation.
> Doing things generically is nice and all, but please do not go around
> removing all of the different implementations and consolidating on the
> simplest point of commonality you could come up with. Either combine
> everything in to a generic show_mem() that doesn't sacrifice
> functionality, or only convert the platforms that are identical.

Sorry, I made it an RFC because I was not quite sure if the generic pfn
walker is valid on all affected architectures.  If it is okay, I will
send a patch-set meant for application that does not miss any output.

Thanks,

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/