[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87abkboykw.fsf@saeurebad.de>
Date: Thu, 03 Apr 2008 15:30:23 +0200
From: Johannes Weiner <hannes@...urebad.de>
To: Sam Ravnborg <sam@...nborg.org>
Cc: Heiko Carstens <heiko.carstens@...ibm.com>,
linux-kernel@...r.kernel.org, linux-mm@...ck.org, mingo@...e.hu,
davem@...emloft.net, hskinnemoen@...el.com, cooloney@...nel.org,
starvik@...s.com, dhowells@...hat.com, ysato@...rs.sf.net,
takata@...ux-m32r.org, geert@...ux-m68k.org, ralf@...ux-mips.org,
kyle@...isc-linux.org, paulus@...ba.org, schwidefsky@...ibm.com,
lethal@...ux-sh.org, jdike@...toit.com, miles@....org,
chris@...kel.net, rmk@....linux.org.uk, tony.luck@...el.com
Subject: Re: [RFC 01/22] Generic show_mem() implementation
Hi,
Sam Ravnborg <sam@...nborg.org> writes:
>> > +
>> > +config HAVE_ARCH_SHOW_MEM
>> > + def_bool y
>>
>> These are all not necessary. Better add some global Kconfig option that
>> gets selected by an arch if it wants the generic implementation.
>>
>> e.g. we currently have this in arch/s390/Kconfig:
>>
>> config S390
>> def_bool y
>> select HAVE_OPROFILE
>> select HAVE_KPROBES
>> select HAVE_KRETPROBES
>>
>> just add a select HAVE_GENERIC_SHOWMEM or something like that in the arch
>> specific patches.
> Seconded.
> See Documentation/kbuild/kconfig-language.txt for a few more hints
> how to do it.
Yes, I will rework the patches. Thanks.
Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists