linux-kernel - Re: usb unbind/bind => WARNING at fs/sysfs/dir.c [Was: 2.6.25-rc8-mm1]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47F7359E.1020105@gmail.com>
Date:	Sat, 05 Apr 2008 10:17:34 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	Greg KH <greg@...ah.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: usb unbind/bind => WARNING at fs/sysfs/dir.c [Was: 2.6.25-rc8-mm1]

On 04/05/2008 05:46 AM, Alan Stern wrote:
> Removing an interface's sysfs files before unregistering the interface
> doesn't work properly, because usb_unbind_interface() will reinstall
> altsetting 0 and thereby create new sysfs files.  This patch (as1074)
> removes the files after the unregistration is finished.  It's not
> quite as clean, but at least it works.
> 
> Also, there's no need to check if an interface has been registered
> before removing its sysfs files.  If it hasn't been registered then
> the files won't have been created, so usb_remove_sysfs_intf_files()
> will simply do nothing.
> 
> Signed-off-by: Alan Stern <stern@...land.harvard.edu>

Tested-by: Jiri Slaby <jirislaby@...il.com>

Works well, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/