lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Pine.LNX.4.44L0.0804051013250.5030-100000@netrider.rowland.org> Date: Sat, 5 Apr 2008 10:16:11 -0400 (EDT) From: Alan Stern <stern@...land.harvard.edu> To: Greg KH <greg@...ah.com> cc: Jiri Slaby <jirislaby@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, Kernel development list <linux-kernel@...r.kernel.org>, USB list <linux-usb@...r.kernel.org> Subject: Re: usb unbind/bind => WARNING at fs/sysfs/dir.c [Was: 2.6.25-rc8-mm1] On Fri, 4 Apr 2008, Greg KH wrote: > > Here's the answer. The bug was introduced when the definition of > > device_is_registered() in include/linux/device.h was changed. The old > > definition returned 0 when called inside a driver's remove method for a > > device being unregistered, whereas the new definition returns 1. I > > don't know when this change was made. > > I've changed that in the -mm tree to make some PCI stuff much easier. I > didn't realize that USB was depending on when this was being set, sorry > about it. > > I like your fix better, it makes the code path much simpler :) Well, it's not really any _simpler_, since all I did was interchange two lines of code. But I agree this way is better. It doesn't depend on the behavior of device_is_registered() in the ill-defined situation where the device is in the middle of being unregistered. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists