linux-kernel - Re: [PATCH] jffs2 summary allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 05 Apr 2008 16:05:43 +0200
From:	matthieu castet <castet.matthieu@...e.fr>
To:	Linux Kernel list <linux-kernel@...r.kernel.org>
CC:	Michael Trimarchi <trimarchimichael@...oo.it>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Josh Boyer <jwboyer@...il.com>
Subject: Re: [PATCH] jffs2 summary allocation

Hi,

I think the main problem is that mtd buffers are not dma compatible [1].
They can be allocated by vmalloc, don't be aligned on a page, ...

The problem was catch on jffs2 summary, but the same things could happen 
in other places.

So for me the correct fix, is either to fix mtd to have all buffer dma 
compatible or either fix mtd_dataflash to don't pass mtd buffer to spi 
stack, but to allocate dma buffer and do some copy.

BTW aren't there sparse annotation to track dma buffer ?

Matthieu

[1] http://article.gmane.org/gmane.linux.drivers.mtd/20663
As for the original question... I'm not sure. At the moment I don't
believe it's true that all such buffers are suitable for DMA. Perhaps it
would be sensible for us to redefine the MTD API so that it is required
(and fix the users).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/