linux-kernel - Re: [PATCH 0/4] x86: add cpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36ca99e90804070707g41d374a5m9b80e77165534f1b@mail.gmail.com>
Date:	Mon, 7 Apr 2008 16:07:28 +0200
From:	"Bert Wesarg" <bert.wesarg@...glemail.com>
To:	"Paul Jackson" <pj@....com>
Cc:	"Mike Travis" <travis@....com>, mingo@...e.hu, tglx@...utronix.de,
	hpa@...or.com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] x86: add cpus_scnprintf function v2

On Mon, Apr 7, 2008 at 10:04 AM, Paul Jackson <pj@....com> wrote:
> I still have some concerns with this cpus_scnprintf patch.
>
>  I've taken them up with Mike offline for initial consideration.
>
>  If others have questions, concerns or enthusiasms for this patch,
>  Mike and I would be interested.
As long as the only justification for this cpus_scnprintf is human
readability, I have concerns too.

Patch 2/4 itself is ok and 4/4 too. The only thing I miss is an export
of NR_CPUS. So that you know in front of reading a kernel mask, what
size your bitmap needs. (for example glibc cpu_set_t has only 1024
bits but has an cpu_set_t with arbitrary size too).

Bert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/