linux-kernel - Re: [PATCH] x86: create array based interface to change page attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47FA8AB4.7060605@linux.intel.com>
Date:	Mon, 07 Apr 2008 13:57:24 -0700
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	Thomas Hellström <thomas@...gstengraphics.com>
CC:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Andi Kleen <andi@...stfloor.org>,
	Dave Airlie <airlied@...hat.com>, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, mingo@...hat.com
Subject: Re: [PATCH] x86: create array based interface to change page attribute

Thomas Hellström wrote:
> Ouch, so we'll be needing an ioremap_wc(), I guess. We probably 
> shouldn't use the linear kernel map for this anyway, since that would 
> require a chipset flush for each ring commit.  We can actually use 
> vmap() with a wc page protection for that, but an ioremap_wc() would 
> certainly save us a lot of trouble.

please don't use vmap() as a hack for mapping IO memory when you should use ioremap_wc()....
Lets get this thing right rather than finding whichever hack of the day
happens to work with the implementation from yesterday.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/