linux-kernel - Re: [PATCH] x86: create array based interface to change page attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200804071402.21548.jbarnes@virtuousgeek.org>
Date:	Mon, 7 Apr 2008 14:02:21 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Arjan van de Ven <arjan@...ux.intel.com>
Cc:	Thomas Hellström <thomas@...gstengraphics.com>,
	Andi Kleen <andi@...stfloor.org>,
	Dave Airlie <airlied@...hat.com>, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, mingo@...hat.com
Subject: Re: [PATCH] x86: create array based interface to change page attribute

On Monday, April 07, 2008 1:56 pm Arjan van de Ven wrote:
> Jesse Barnes wrote:
> > Yeah, they're ioremapped now, but that's a problem since with the PAT
> > patches they'll be mapped hard UC (right now it just happens to work).
>
> clearly this needs to use ioremap_wc(), I was assuming nothing else....
> (code mapping things uncached and then frobbing the MTRR's underneath
> really shouldn't be allowed to live from 2.6.26 and forward. Esp for the 3D
> drivers we KNOW that we want _wc so that is a clear case of just fixing the
> code to do the right thing)

Totally agreed, the AGP code needs to be specific about what it wants...

Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/