linux-kernel - Re: [PATCH 5/6] Clocklib: Use correct clock for IrDA on pxa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080407230434.GA525@flint.arm.linux.org.uk>
Date:	Tue, 8 Apr 2008 00:04:34 +0100
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Dmitry Baryshkov <dbaryshkov@...il.com>,
	linux-kernel@...r.kernel.org, haavard.skinnemoen@...el.com,
	lethal@...ux-sh.org, philipp.zabel@...il.com, pavel@....cz,
	tony@...mide.com, paul@...an.com
Subject: Re: [PATCH 5/6] Clocklib: Use correct clock for IrDA on pxa

On Mon, Apr 07, 2008 at 04:00:29PM -0700, Andrew Morton wrote:
> On Thu, 3 Apr 2008 17:24:02 +0400
> Dmitry Baryshkov <dbaryshkov@...il.com> wrote:
> 
> > Signed-off-by: Dmitry Baryshkov <dbaryshkov@...il.com>
> > ---
> >  drivers/net/irda/pxaficp_ir.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/net/irda/pxaficp_ir.c b/drivers/net/irda/pxaficp_ir.c
> > index 8c09344..36d2ec0 100644
> > --- a/drivers/net/irda/pxaficp_ir.c
> > +++ b/drivers/net/irda/pxaficp_ir.c
> > @@ -814,7 +814,7 @@ static int pxa_irda_probe(struct platform_device *pdev)
> >  	si->dev = &pdev->dev;
> >  	si->pdata = pdev->dev.platform_data;
> >  
> > -	si->sir_clk = clk_get(&pdev->dev, "UARTCLK");
> > +	si->sir_clk = clk_get(&pdev->dev, "SIRCLK");
> >  	si->fir_clk = clk_get(&pdev->dev, "FICPCLK");
> >  	if (IS_ERR(si->sir_clk) || IS_ERR(si->fir_clk)) {
> >  		err = PTR_ERR(IS_ERR(si->sir_clk) ? si->sir_clk : si->fir_clk);
> 
> When fixing a bug, please describe what the bug is, and how the patch fixes
> it.
> 
> A patch needs to be very very obvious to be able to get away with no
> changelog, and this one is not very very obvious.

It's not a bug fix - it's a stupidity of the clock lib that the API
doesn't really require.

I've not made up my mind what to do with this stuff, but if it requires
drivers to work around its short comings, then I'm not in favour of it.

(We have the above code working as is.)

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/