linux-kernel - Re: [PATCH 1/1] checkpatch: nested structs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080408173548.GG17915@shadowen.org>
Date:	Tue, 8 Apr 2008 18:35:48 +0100
From:	Andy Whitcroft <apw@...dowen.org>
To:	Jan Engelhardt <jengelh@...putergmbh.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] checkpatch: nested structs

On Tue, Apr 08, 2008 at 04:55:30PM +0200, Jan Engelhardt wrote:
> This is required for nested struct/union compounds.
> ---
>  scripts/checkpatch.pl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 58a9494..cf78e86 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1582,7 +1582,7 @@ sub process {
>  
>  # closing brace should have a space following it when it has anything
>  # on the line
> -		if ($line =~ /}(?!(?:,|;|\)))\S/) {
> +		if ($line =~ /}+(?!(?:,|;|\)))\S/) {
>  			ERROR("space required after that close brace '}'\n" . $herecurr);
>  		}

If my eyes are not lying then you have added is a + after the first },
as this is an unanchored match I would expect that to match in exactly
the same places.  Hmm, well I guess that it would allow two or more close
braces to abutt.  Can you give me an example of somethign which would
require this?

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/