linux-kernel - RE: [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e1000 toe1000e migration of PCI Express devices)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36D9DB17C6DE9E40B059440DB8D95F5204E2A55C@orsmsx418.amr.corp.intel.com>
Date:	Tue, 8 Apr 2008 12:43:00 -0700
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	"Ingo Molnar" <mingo@...e.hu>,
	"Kok, Auke-jan H" <auke-jan.h.kok@...el.com>
Cc:	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"NetDev" <netdev@...r.kernel.org>,
	"e1000-list" <e1000-devel@...ts.sourceforge.net>,
	"linux-pci maillist" <linux-pci@...ey.karlin.mff.cuni.cz>,
	"Jeff Garzik" <jeff@...zik.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Greg KH" <greg@...ah.com>,
	"Arjan van de Ven" <arjan@...ux.intel.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: RE: [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e1000 toe1000e migration of PCI Express devices)

Auke is out sick, so I'm responding...

Ingo Molnar wrote:
> this is a simple bzImage kernel, no modules at all. Here's the full
> regression report:

then why are you compiling e1000e as a module?  no "=y" in your kernel
means no support, and this kernel .config has e1000e supporting your
hardware.

your expectation is that e1000 once loaded on this device in a previous
kernel (2.6.24) so it should continue to work, right?  I see your point
but we are trying to make general improvements to both drivers, and the
best way forward was a split, in order to make the user experience
better by eliminating chances for regressions on older hardware.  

> v2.6.25-rc8 regresses relative to v2.6.24, with the following config,
> which config works fine in v2.6.24:

> the eth0 interface is not detected at all:
>    http://redhat.com/~mingo/misc/dmesg.e1000.bad

if you're running a no module kernel, you'll need to set CONFIG_E1000E=y
for your device to be detected.  

> so the pure presence of the e1000e module breaks the e1000 driver.
> That 
> is a regression and a bug that should be fixed.

The device IDs moved to e1000e, we don't want collisions between drivers
that support the same IDs, so to avoid those user support issues, we're
trying to make the process as painless as possible with announcements
and time.  The distros are already including the e1000e driver in their
builds and new installs with the new ID layout will automatically select
the correct driver for their hardware.

Users that take an upgrade to their kernel (with e1000e enabled) might
benefit if the distro upgrading that kernel included a post upgrade
script that migrated e1000e devices previously using e1000 in
modprobe.conf to alias ethX e1000e

If there is a more reasonable solution you can come up with I am
interested.

Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/