[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080408195123.GA28148@elte.hu>
Date: Tue, 8 Apr 2008 21:51:23 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Matthew Wilcox <matthew@....cx>
Cc: "Kok, Auke" <auke-jan.h.kok@...el.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
NetDev <netdev@...r.kernel.org>,
e1000-list <e1000-devel@...ts.sourceforge.net>,
linux-pci maillist <linux-pci@...ey.karlin.mff.cuni.cz>,
Jeff Garzik <jeff@...zik.org>,
Andrew Morton <akpm@...ux-foundation.org>,
"David S. Miller" <davem@...emloft.net>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Jesse Brandeburg <jesse.brandeburg@...el.com>,
"Ronciak, John" <john.ronciak@...el.com>,
"Allan, Bruce W" <bruce.w.allan@...el.com>,
Greg KH <greg@...ah.com>,
Arjan van de Ven <arjan@...ux.intel.com>,
"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e1000 to
e1000e migration of PCI Express devices)
* Matthew Wilcox <matthew@....cx> wrote:
> On Tue, Apr 08, 2008 at 08:39:21PM +0200, Ingo Molnar wrote:
> > so the pure presence of the e1000e module breaks the e1000 driver. That
> > is a regression and a bug that should be fixed.
>
> I think you've found the wrong problem ... it looks deliberate to me
> that enabling e1000e disables e1000 from claiming the PCI IDs (see the
> PCIE() macro right before the e1000_pci_tbl in
> drivers/net/e1000/e1000_main.c).
>
> The question is why e1000e isn't claiming the device ...
because i have e1000 built-in and dont load the e1000e module at all.
That worked before and doesnt work now.
the solution is rather straightforward: if E1000 is built-in then E1000E
should be built-in as well or disabled (i.e. it should not be possible
to build it as a module in that case) - because the PCI ID stealing
trick now connects the two drivers unconditionally. [ If e1000 is a
module then e1000e can be a module (or disabled) - this would be the
most common configuration. ]
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists