linux-kernel - Re: [PATCH 4/4] pxafb: preliminary smart panel interface support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080408012359.d0a7d0c8.akpm@linux-foundation.org>
Date:	Tue, 8 Apr 2008 01:23:59 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"eric miao" <eric.y.miao@...il.com>
Cc:	"linux-arm-kernel email list" 
	<linux-arm-kernel@...ts.arm.linux.org.uk>,
	linux-fbdev-devel@...ts.sourceforge.net,
	lkml <linux-kernel@...r.kernel.org>,
	"Russell King - ARM Linux" <linux@....linux.org.uk>,
	"Daniel Mack" <daniel@...aq.de>
Subject: Re: [PATCH 4/4] pxafb: preliminary smart panel interface support

On Tue, 8 Apr 2008 12:07:27 +0800 "eric miao" <eric.y.miao@...il.com> wrote:

> +static int pxafb_smart_thread(void *arg)
> +{
> +	struct pxafb_info *fbi = (struct pxafb_info *) arg;

Please don't typecast when assigning a pointer to or from void*.

Reasons:

- It defeats typechecking: if someone later converts `arg' to a u8, they
  won't even get a compiler warning.

- Improved code readability.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/