[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <1207748251.8303.31.camel@heimdal.trondhjem.org>
Date: Wed, 09 Apr 2008 09:37:31 -0400
From: Trond Myklebust <Trond.Myklebust@...app.com>
To: Christoph Hellwig <hch@...radead.org>,
Bryan Wu <cooloney@...nel.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT] Please pull NFS client fixes against linux-2.6.25-rc8
On Wed, 2008-04-09 at 09:27 -0400, Christoph Hellwig wrote:
> On Wed, Apr 09, 2008 at 09:12:38AM -0400, Trond Myklebust wrote:
> > That is what this does. For the case of no mmu, generic_file_mmap()
> > compiles into a 'return -ENOSYS;'
>
> doh, I was under the impression we had a real implementation now.
> Of course then it makes much more sense to just not set .mmap at all,
> which gives the same effect in a more obvious way and without any
> confusion to the reader. (actually that one gives -ENODEV which I
> assume is for some reason more appropinquate)
I'm assuming there is a reason why the nommu folks want to return ENOSYS
rather than ENODEV when mmap() is unsupported by the hardware.
Bryan, any comments to that?
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@...app.com
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists