linux-kernel - Re: [regression] e1000e broke e1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080409191256.GB9276@elte.hu>
Date:	Wed, 9 Apr 2008 21:12:56 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	"Kok, Auke" <auke-jan.h.kok@...el.com>
Cc:	Jeff Garzik <jeff@...zik.org>, Matthew Wilcox <matthew@....cx>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	NetDev <netdev@...r.kernel.org>,
	e1000-list <e1000-devel@...ts.sourceforge.net>,
	linux-pci maillist <linux-pci@...ey.karlin.mff.cuni.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	Greg KH <greg@...ah.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [regression] e1000e broke e1000

* Kok, Auke <auke-jan.h.kok@...el.com> wrote:

> > it is an obvious regression that could and should be solved in the 
> > Kconfig space: do not allow E1000=y && E1000E=m.
> 
> this is really not the solution imho, having e1000 builtin and e1000e 
> as a module is a perfectly viable choice. They are two separate 
> drivers that are completely independent.

you try to argue against a strong and established concept that Linux 
always had from day one on: DRIVER_X=y means the user prefers that 
driver so strongly that he has selected it built-in. Such drivers are 
special in every sense: they run first before any of the module init, 
they cannot be disabled, etc. etc.

The only case where that should be overriden as the primary driver for 
that piece of hardware if _another_ driver is built-in _too_.

... which is exactly the E1000=y && E1000E=m regression that bit me and 
the simple solution of forcing E1000E to follow the mode of the E1000 
driver solves it.

The most common distro setup is E1000=m and E1000E=m. The most common 
embedded setup is _one_ of the two drivers as =y. So i'm not sure why 
you are arguing about all this. Please just fix this bug, simple as 
that.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/