linux-kernel - Re: [patch] eventfd/kaio integration fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080409120812.cad8f173.akpm@linux-foundation.org>
Date:	Wed, 9 Apr 2008 12:08:12 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Davide Libenzi <davidel@...ilserver.org>
Cc:	linux-kernel@...r.kernel.org, zach.brown@...cle.com,
	jroberson@...sapeake.net
Subject: Re: [patch] eventfd/kaio integration fix

On Wed, 9 Apr 2008 11:45:47 -0700 (PDT)
Davide Libenzi <davidel@...ilserver.org> wrote:

> Jeff Roberson discovered a race when using kaio eventfd based 
> notifications. This patch fixes the race by moving the notification inside 
> the spinlocked section of kaio.

Missing information.

What are the consequences of this race, when it occurs?

> The operation is safe since eventfd 
> spinlock and kaio one are unrelated.

Yes, it's safe from that perspective.

However with this patch applied, we will no longer run eventfd_signal() if
kiocbIsCancelled(iocb).  Convincing is needed, please?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/