[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080409084606.GD19010@one.firstfloor.org>
Date: Wed, 9 Apr 2008 10:46:06 +0200
From: Andi Kleen <andi@...stfloor.org>
To: Andy Whitcroft <apw@...dowen.org>
Cc: Andi Kleen <andi@...stfloor.org>,
Jan Engelhardt <jengelh@...putergmbh.de>,
Andrew Morton <akpm@...ux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [patch] checkpatch: relax spacing and line length
> Oh, and if people felt that the concensus was for something to be
> implemented and that you are waiting for me to implement the change in
> checkpatch; please say so.
Well at least I think the printk change is a good one to implement and there
wasn't much protest to it at least.
If you're looking for another change request I think dropping the trailing
white space check would be good a idea because a lot of maintainers already
handle that automatically and it is not really worth bothering the "leaf
developers" with because that can be trivially automated.
Also I still think --file needs to go, or at least be replaced with
--file-force and warning. See the recent unpleasant incident it caused
again, e.g.
http://thread.gmane.org/gmane.linux.kernel/656847/focus=657003
and
http://thread.gmane.org/gmane.linux.kernel/656847/focus=657003
-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists