linux-kernel - Re: [patch] e1000=y && e1000e=m regression fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0804111655520.6058@asgard>
Date:	Fri, 11 Apr 2008 16:58:33 -0700 (PDT)
From:	david@...g.hm
To:	Jeff Garzik <jeff@...zik.org>
cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Daniel Barkalow <barkalow@...ervon.org>,
	Christoph Hellwig <hch@...radead.org>,
	"Kok, Auke" <auke-jan.h.kok@...el.com>,
	Ingo Molnar <mingo@...e.hu>, Matthew Wilcox <matthew@....cx>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	NetDev <netdev@...r.kernel.org>,
	e1000-list <e1000-devel@...ts.sourceforge.net>,
	linux-pci maillist <linux-pci@...ey.karlin.mff.cuni.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	Greg KH <greg@...ah.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [patch] e1000=y && e1000e=m regression fix

On Fri, 11 Apr 2008, Jeff Garzik wrote:

> Linus Torvalds wrote:
>> .. but that said, I think your patch is certainly better than what we have 
>> now (or what Ingo was complaining about for the next merge window). I 
>> certainly could live with it. I would just suggest against ever then 
>> removing that "generic E1000" choice.
>
>
> You mean never ever remove PCI-E support from e1000?
>
> Won't that will inflict long term headaches on the people that matter most -- 
> users and maintainers -- to avoid short term headaches for kernel power 
> users?

no, it sounds like he's saying make the E1000 option select both E1000_PCI 
and E1000_PCIE (which could be selected seperately) and never remove the 
E1000 option.

after people trust the E1000e driver the PCI ids can be removed from 
E1000, but people who only select E1000 will continue to work becouse the 
build system will now build both the PCI and PCI-e drivers when E1000 is 
selected.

David Lang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/