linux-kernel - Re: [patch] e1000=y && e1000e=m regression fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080412130733.GA21572@infradead.org>
Date:	Sat, 12 Apr 2008 09:07:33 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Daniel Barkalow <barkalow@...ervon.org>,
	Christoph Hellwig <hch@...radead.org>,
	"Kok, Auke" <auke-jan.h.kok@...el.com>,
	Ingo Molnar <mingo@...e.hu>, Matthew Wilcox <matthew@....cx>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	NetDev <netdev@...r.kernel.org>,
	e1000-list <e1000-devel@...ts.sourceforge.net>,
	linux-pci maillist <linux-pci@...ey.karlin.mff.cuni.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	Greg KH <greg@...ah.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [patch] e1000=y && e1000e=m regression fix

On Fri, Apr 11, 2008 at 07:43:49PM -0400, Jeff Garzik wrote:
> However, due to a mistake now released to the public -- a tiny few PCI-E 
> chips are supported by e1000 -- you have a widely disparate feature set:
>
> 	e1000, old chips:		full support
>
> 	e1000, a few PCI-E chips:	basic support
>
> 	e1000e, all PCI-E chips:	full support
>
> Since e1000e is all new and fancy AND CLEAN, the code for the same chips is 
> different -- thus Intel must make every PCI-E fix _twice_.
>
> It also means WE HAVE TO KEEP TOUCHING E1000, while supporting PCI-E chips. 
>  After this PCI-E issue is resolved, I want to let e1000 sit and be stable 
> and not be touched.
>
> For a temporary situation, this is fine.  Give me transition suggestions, 
> please!

PCI-E support should be removed from the e1000 driver ASAP, that is .26.
What we need is a way to have CONFIG_E1000 pull in the e1000e driver
automatically to not confuse kernel developers that don't know what
hardware they actually have..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/