linux-kernel - Re: [patch] checkpatch: relax spacing and line length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 13 Apr 2008 16:18:45 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Benny Halevy <bhalevy@...asas.com>
Cc:	Andy Whitcroft <apw@...dowen.org>,
	Jan Engelhardt <jengelh@...putergmbh.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	SL Baur <steve@...acs.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Richard Knutsson <ricknu-0@...dent.ltu.se>,
	Stefan Richter <stefanr@...6.in-berlin.de>
Subject: Re: [patch] checkpatch: relax spacing and line length

On Sun, Apr 13, 2008 at 12:53:48PM +0300, Benny Halevy wrote:

> > Sorry.  I'm not going to change perfectly working editing habits *or* to patch
> 
> That's working well for you but apparently not so well for everybody else.

Nice turn of a phrase, that.

> > nvi to satisfy an annoying wunch of bankers.  HAND, GAFL.
> > --
> 
> Thanks for the insightful and mature comment, Al.

Oh, for the...

> I really hate to spend more time on this topic but folks did find merits in it.
> There's no need to change anybody's editing habits if we allow this indentation
> style in the CodingStyle document and in checkpatch.pl in addition to the
> existing convention.

"Allow" is such a nice word, isn't it?  Let's take a closer look:
	* nobody prohibits lines satisfying your constraints ("tabs only for
indent level"), so "allowing" that is meaningless
	* "indentation style" in the above refers to editor settings.
To "allow" that, you advocate prohibiting the lines _NOT_ satisfying your
constraints.  Which, by definition, means extra work for people submitting
patches, no matter how you spin it.

BTW, while we are talking about conventions, would you mind keeping lines
in your mail shorter than 79 columns to avoid wraparounds in quoted text?
Unlike your proposal, that one actually _is_ a common convention...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/