linux-kernel - Re: [patch] checkpatch: relax spacing and line length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4801D82C.7000901@panasas.com>
Date:	Sun, 13 Apr 2008 12:53:48 +0300
From:	Benny Halevy <bhalevy@...asas.com>
To:	Al Viro <viro@...IV.linux.org.uk>
CC:	Andy Whitcroft <apw@...dowen.org>,
	Jan Engelhardt <jengelh@...putergmbh.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	SL Baur <steve@...acs.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Richard Knutsson <ricknu-0@...dent.ltu.se>,
	Stefan Richter <stefanr@...6.in-berlin.de>
Subject: Re: [patch] checkpatch: relax spacing and line length

On Apr. 12, 2008, 3:26 +0300, Al Viro <viro@...IV.linux.org.uk> wrote:
> On Wed, Apr 09, 2008 at 08:02:39PM +0300, Benny Halevy wrote:
> 
>> I'm not sure what "two space change" proposal this Steve referred to
>> and his rejection is based on not-to-sound aesthetic grounds.
>>
>> The motivation behind our proposal is more than just aesthetic.
>> I believe that using tabs for indent and then spaces for alignment
>> is functionally better, works for everybody, and will eventually result
>> in a more readable code over time, hopefully leading to fewer bugs.
> 
> Sorry.  I'm not going to change perfectly working editing habits *or* to patch

That's working well for you but apparently not so well for everybody else.

> nvi to satisfy an annoying wunch of bankers.  HAND, GAFL.
> --

Thanks for the insightful and mature comment, Al.

I really hate to spend more time on this topic but folks did find merits in it.
There's no need to change anybody's editing habits if we allow this indentation
style in the CodingStyle document and in checkpatch.pl in addition to the
existing convention.

Benny

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/