[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1208173181.3351.63.camel@moss.renham>
Date: Mon, 14 Apr 2008 21:39:41 +1000
From: Ben Nizette <bn@...sdigital.com>
To: Uwe Kleine-König <Uwe.Kleine-Koenig@...i.com>
Cc: linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: UIO: Implement a UIO interface for the SMX Cryptengine
[putting lkml back in CC]
On Mon, 2008-04-14 at 12:08 +0200, Uwe Kleine-König wrote:
> The line "depends on UIO" isn't needed (anymore) because the whole
> config item is located in a "if UIO"/"endif".
Right, just saw your patch fly by. Given mine's been taken up by gregkh
already I was kinda hoping someone further up the tree would end up
fixing it. If not I can of course rebase and resend.
>
> The "default n" isn't necessary because that's the default anyhow.
Eh, I like to be explicit.
>
> I didn't look deeper into that patch, but it might be possible to
share
> code with my patch
Indeed, I quite like your patch. I spend a fair bit of time on the
AVRFreaks AVR32 support community and I can see a great need for what
you've done. That said, if HJK/ GregKH don't object I think I'll leave
mine pretty much as-is; having a device-specific ISR in platform code
just doesn't quite sit smooth with me :-)
Thanks!
--Ben.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists