linux-kernel - Re: [PATCH 13/33 replaces 14/35 and 15/35] W1: w1_slave_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080414114055.GA13385@2ka.mipt.ru>
Date:	Mon, 14 Apr 2008 15:40:55 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	David Fries <david@...es.net>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 13/33 replaces 14/35 and 15/35] W1: w1_slave_read_id multiple short read bug

Hi David.

On Sun, Apr 13, 2008 at 06:15:37PM -0500, David Fries (david@...es.net) wrote:
> This is more to point out the bug in w1_slave_read_id, the next patch
> rewrites the routine.
> 
> w1.c 1.15
... 
> w1.c 1.16

That is what I talked about. I agree with your analysis of the problem
and I agree with fixes. But I do not agree with how you created them:
why do we ever neen 1.15 version, since immediately after that we have
1.16 which completely rewrite what was done in previous one?
This applies to the whole patchset: there are essentially several bug
fixes and several features, so separate them into several patches, which
do not collide with each other in the above way.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/