linux-kernel - Re: [patch] F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.00.0804140742380.2820@woody.linux-foundation.org>
Date:	Mon, 14 Apr 2008 07:48:41 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Christoph Hellwig <hch@...radead.org>
cc:	Davide Libenzi <davidel@...ilserver.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@....linux.org.uk>
Subject: Re: [patch] F_GETPATH for linux

On Mon, 14 Apr 2008, Christoph Hellwig wrote:
> 
> Adding a duplicated API like this is rather pointless.  Especially as
> the readlink is easier and makes more sense.

Well, I wouldn't say "makes more sense". It may be more traditional (for 
Linux), but it has its problems, notably performance. One use of F_GETPATH 
is for server code, to check that a previous open() didn't follow symlinks 
to outside of some specified area.

Not that I like F_GETPATH much either, but portability is a strong enough 
argument that coming up with some *other* way is probably not great.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/