linux-kernel - Re: [patch] F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0804141030060.20665@alien.or.mcafeemobile.com>
Date:	Mon, 14 Apr 2008 10:34:16 -0700 (PDT)
From:	Davide Libenzi <davidel@...ilserver.org>
To:	Christoph Hellwig <hch@...radead.org>
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@....linux.org.uk>
Subject: Re: [patch] F_GETPATH for linux

On Mon, 14 Apr 2008, Christoph Hellwig wrote:

> On Sun, Apr 13, 2008 at 03:00:53PM -0700, Davide Libenzi wrote:
> > I was working on some bsd/linux compatibility code, and I noticed that we 
> > do not have F_GETPATH. I know we can readlink /proc/PID/fd/FD (that is 
> > what I'm doing now, under #ifdef), but I gave a patch a shot anyway.
> > Here it is, building but untested ...
> 
> Adding a duplicated API like this is rather pointless.  Especially as
> the readlink is easier and makes more sense.

As I said, we can do it in the other way. I struck this one when trying to 
work out (read port) some BSD code to Linux. IMO, given that the patch 
does virtually only add an F_GETPATH define in fcntl.h, and a case in the 
fcntl switch, it may be worth considering.



- Davide


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/