linux-kernel - Re: [Patch] arch/um/os-Linux/sys-i386/task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080414145917.GC7186@c2.user-mode-linux.org>
Date:	Mon, 14 Apr 2008 10:59:17 -0400
From:	Jeff Dike <jdike@...toit.com>
To:	WANG Cong <xiyou.wangcong@...il.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...l.org,
	user-mode-linux-devel@...ts.sourceforge.net
Subject: Re: [Patch] arch/um/os-Linux/sys-i386/task_size.c: improve a bit

On Sat, Apr 12, 2008 at 05:17:47PM +0800, WANG Cong wrote:
> Improve this code a bit: check sigaction's return value and remove a useless
> fflush().

This looks fine.  BTW, some of the fflushing is on purpose, although
the one you removed does indeed look useless.  I want all output from
early boot to hit the screen as soon as possible, even in the absence
(so far) of a newline.  So, if there's any doubt about whether a
printf has a newline in it, it's flushed.

       	     	     Jeff

-- 
Work email - jdike at linux dot intel dot com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/