linux-kernel - Re: [PATCH 2/2] fix sys_unshare()+SEM_UNDO: perform an implicit CLONE_SYSVSEM in CLONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080414150057.GB15667@sergelap.austin.ibm.com>
Date:	Mon, 14 Apr 2008 10:00:57 -0500
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	Manfred Spraul <manfred@...orfullife.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"Serge E. Hallyn" <serue@...ibm.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Pavel Emelyanov <xemul@...nvz.org>,
	Sukadev Bhattiprolu <sukadev@...ibm.com>
Subject: Re: [PATCH 2/2] fix sys_unshare()+SEM_UNDO: perform an implicit
	CLONE_SYSVSEM in CLONE_NEWIPC

Quoting Manfred Spraul (manfred@...orfullife.com):
> sys_unshare(CLONE_NEWIPC) doesn't handle the undo lists properly, this can
> cause a kernel memory corruption. CLONE_NEWIPC must detach from the existing
> undo lists.
> Fix, part 2: perform an implicit CLONE_SYSVSEM in CLONE_NEWIPC.
> CLONE_NEWIPC creates a new IPC namespace, the task cannot access the
> existing semaphore arrays after the unshare syscall. Thus the task
> can/must detach from the existing undo list entries, too.
> 
> This fixes the kernel corruption, because it makes it impossible that
> undo records from two different namespaces are in sysvsem.undo_list.

So this was never an issue with clone(CLONE_NEWIPC|CLONE_SYSVSEM), which
should have had the same result as unshare(CLONE_NEWIPC&~CLONE_SYSVSEM)?

> I'm not sure who's the right maintainer, Andrew, could you merge it?
> 
> Signed-off-by: Manfred Spraul <manfred@...orfullife.com>
> ---
>  kernel/fork.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 7f242b0..6f956a7 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -1735,9 +1735,13 @@ asmlinkage long sys_unshare(unsigned long unshare_flags)
>  		goto bad_unshare_cleanup_semundo;
> 
>  	if (new_fs ||  new_mm || new_fd || new_ulist || new_nsproxy) {
> -		if (unshare_flags & CLONE_SYSVSEM) {
> +		if (unshare_flags & (CLONE_NEWIPC|CLONE_SYSVSEM)) {
>  			/*
>  			 * CLONE_SYSVSEM is equivalent to sys_exit().
> +			 *
> +			 * CLONE_NEWIPC must also detach from the undolist: after switching
> +			 * to a new ipc namespace, the semaphore arrays from the old
> +			 * namespace are unreachable.
>  			 */
>  			exit_sem(current);
>  		}
> -- 
> 1.5.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/