| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 Apr 2008 11:43:42 -0400 From: Jeff Dike <jdike@...toit.com> To: WANG Cong <xiyou.wangcong@...il.com> Cc: linux-kernel@...r.kernel.org, akpm@...l.org, user-mode-linux-devel@...ts.sourceforge.net Subject: Re: [Patch] UML: Fix another build error On Sat, Apr 12, 2008 at 11:39:14PM +0800, WANG Cong wrote: > > This patch fixes the following build error. > > CC arch/um/drivers/mconsole_kern.o > /home/wangcong/projects/linux-2.6/arch/um/drivers/mconsole_kern.c:337: error: redefinition of ‘mconsole_register_dev’ > /home/wangcong/projects/linux-2.6/arch/um/include/mconsole_kern.h:47: error: previous definition of ‘mconsole_register_dev’ was here > make[2]: *** [arch/um/drivers/mconsole_kern.o] Error 1 > make[1]: *** [arch/um/drivers/mconsole_kern.ko] Error 2 > make: *** [sub-make] Error 2 This one is fishy. For one thing, it looks like you reproduce this with !CONFIG_MCONSOLE, but I just successfully built a !CONFIG_MCONSOLE UML. Second, the arch/um/drivers/Makefile looks to me (and the build log confirms) that mconsole_kern.c isn't compiled with !CONFIG_MCONSOLE. Third, you should ask yourself if there might be a deeper problem that needs fixing if you find yourself putting #ifdef CONFIG_FOO in files which implement FOO. Jeff -- Work email - jdike at linux dot intel dot com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists