linux-kernel - Re: [2.6 patch] add include/asm-avr32/xor.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0804141530i7c6ee03codeb0a546d333cb2f@mail.gmail.com>
Date:	Mon, 14 Apr 2008 18:30:47 -0400
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Dan Williams" <dan.j.williams@...el.com>
Cc:	"Adrian Bunk" <bunk@...nel.org>,
	"Sebastian Siewior" <linux-crypto@...breakpoint.cc>,
	hskinnemoen@...el.com, herbert@...dor.apana.org.au,
	davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, shannon.nelson@...el.com
Subject: Re: [2.6 patch] add include/asm-avr32/xor.h

On Mon, Apr 14, 2008 at 6:27 PM, Dan Williams <dan.j.williams@...el.com> wrote:
> On Mon, Apr 14, 2008 at 3:11 PM, Mike Frysinger <vapier.adi@...il.com> wrote:
>  > On Mon, Apr 14, 2008 at 6:01 PM, Adrian Bunk <bunk@...nel.org> wrote:
>  >  > On Mon, Apr 14, 2008 at 11:46:40PM +0200, Sebastian Siewior wrote:
>  > >  > so most
>  >  >  > xor.h files are identical copies and this is probably as bad as a
>  >  >  > trailing white space :)
>  >  >
>  >  >  I'm not sure whether it's worth spending my time discussing whether
>  >  >  adding a config variable to 6 architectures is really better than
>  >  >  adding trivial headers to 3 architectures...
>  >
>  >  long term robustness for new ports/codedrops indicates that having a
>  >  common header in linux/ and making arches opt-in via Kconfig/whatever
>  >  makes life a lot easier for everyone
>  >
>  >  everything builds by default with the generic C versions and arches
>  >  dont have to go through and figure out all the fun little stub files
>  >  they need to straight copy from other architectures ... they only have
>  >  to care if they want to implement an optimized version
>
>  "arches" did not have to go through and figure out the fun little stub
>  file for xor.h.  Adrian already made your "life easier".

actually he didnt.  he posted a fix for avr32.  i dont care about
avr32, i'm a blackfin guy.  he also wouldnt have had to do anything at
all if everything was handled with indirection in linux/xor.h.

your point also is irrelevant in the case of new architectures.  poor
microblaze for example.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/