linux-kernel - Re: [2.6 patch] add include/asm-avr32/xor.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 Apr 2008 20:47:03 -0400
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Dan Williams" <dan.j.williams@...el.com>
Cc:	"Adrian Bunk" <bunk@...nel.org>,
	"Sebastian Siewior" <linux-crypto@...breakpoint.cc>,
	hskinnemoen@...el.com, herbert@...dor.apana.org.au,
	davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, shannon.nelson@...el.com
Subject: Re: [2.6 patch] add include/asm-avr32/xor.h

On Mon, Apr 14, 2008 at 7:45 PM, Dan Williams <dan.j.williams@...el.com> wrote:
> On Mon, Apr 14, 2008 at 3:30 PM, Mike Frysinger <vapier.adi@...il.com> wrote:
>  > On Mon, Apr 14, 2008 at 6:27 PM, Dan Williams <dan.j.williams@...el.com> wrote:
> >  >  "arches" did not have to go through and figure out the fun little stub
>  >  >  file for xor.h.  Adrian already made your "life easier".
>  >
>  >  actually he didnt.  he posted a fix for avr32.  i dont care about
>  >  avr32, i'm a blackfin guy.  he also wouldnt have had to do anything at
>  >  all if everything was handled with indirection in linux/xor.h.
>  >
>  >  your point also is irrelevant in the case of new architectures.  poor
>  >  microblaze for example.
>
>  Don't get me wrong I see the pain-reducing-value in codifying all the
>  features that have architecture specific aspects with HAVE_* config
>  variables.  But in this case I think a 6 line patch per new arch gets
>  the immediate job done.

sure ... i see the original patch as OK to get things working now
(especially as that is how the xor stuff is currently architected).
bigger picture is to go the common route proposed by Sebastian.  now
just need to sucker someone into doing the footwork :).
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/