linux-kernel - Re: [PATCH 2/3] x86: Implement prctl PR_GET_TSC and PR_SET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080415074630.GA16721@elte.hu>
Date:	Tue, 15 Apr 2008 09:46:30 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Erik Bosman <ebn310@....vu.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrea Arcangeli <andrea@...share.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] x86: Implement prctl PR_GET_TSC and PR_SET_TSC


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> > --- a/arch/x86/kernel/process_32.c
> > +++ b/arch/x86/kernel/process_32.c
> > @@ -36,6 +36,7 @@
> >  #include <linux/personality.h>
> >  #include <linux/tick.h>
> >  #include <linux/percpu.h>
> > +#include <linux/prctl.h>
> > 
> >  #include <asm/uaccess.h>
> >  #include <asm/pgtable.h>
> > @@ -528,11 +529,12 @@ start_thread(struct pt_regs *regs, unsigned long new_ip, unsigned long new_sp)
> >  }
> >  EXPORT_SYMBOL_GPL(start_thread);
> > 
> > -#ifdef CONFIG_SECCOMP
> > +#ifdef CONFIG_DISABLE_TSC
> >  static void hard_disable_TSC(void)
> >  {
> >  	write_cr4(read_cr4() | X86_CR4_TSD);
> >  }
> 
> Won't this break this build if CONFIG_DISABLE_TSC=n and 
> CONFIG_SECCOMP=y?

it would break - but there was an update patch to this 2/3 patch which 
was the one i picked up into x86.git yesterday and which worked fine in 
500 overnight randconfig build and bootup tests.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/