linux-kernel - Re: [Fwd: [-mm] Add an owner to the mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080415195950.GA113@tv-sign.ru>
Date:	Tue, 15 Apr 2008 23:59:50 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Paul Menage <menage@...gle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	balbir@...ux.vnet.ibm.com, serue@...ibm.com,
	penberg@...helsinki.fi, linux-kernel@...r.kernel.org
Subject: Re: [Fwd: [-mm] Add an owner to the mm_struct (v9)]

On 04/15, Paul Menage wrote:
>
> On Tue, Apr 15, 2008 at 10:13 AM, Oleg Nesterov <oleg@...sign.ru> wrote:
> >
> >  Let's suppose the process with a lot of threads does exit_group() and nobody
> >  else uses this ->mm. How many time we will re-assign mm->owner and iterate
> >  over the all threads in system ?
> >
> 
> In general we won't get to the third loop, since one of the first two
> loops (children or siblings) will find another mm user.

Well yes, the second loop checks parent->children ... all sub-threads have
the same parent.

I'd suggest to use ->real_parent though. And the third loop could be

	for_each_process(g) {
		c = g;
		do {
			if (!c->mm)
				continue;
			if (c->mm != mm)
				break;
			goto assign_new_owner;
		} while_each_thread(g, c);
	}

Still. can't we make mm->mm_users_list ?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/