lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080416.213712.78410382.davem@davemloft.net>
Date:	Wed, 16 Apr 2008 21:37:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	12o3l@...cali.nl
Cc:	hadi@...erus.ca, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_init()

From: Roel Kluin <12o3l@...cali.nl>
Date: Thu, 17 Apr 2008 05:33:21 +0200

> 'datalen' is unsigned, use 'ret' instead to catch a negative return value.
> 
> Signed-off-by: Roel Kluin <12o3l@...cali.nl>
> ---
> diff --git a/net/sched/act_simple.c b/net/sched/act_simple.c
> index fbde461..b78d015 100644
> --- a/net/sched/act_simple.c
> +++ b/net/sched/act_simple.c
> @@ -114,9 +114,10 @@ static int tcf_simp_init(struct nlattr *nla, struct nlattr *est,
>  	if (defdata == NULL)
>  		return -EINVAL;
>  
> -	datalen = nla_len(tb[TCA_DEF_DATA]);
> -	if (datalen <= 0)
> +	ret = nla_len(tb[TCA_DEF_DATA]);
> +	if (ret <= 0)
>  		return -EINVAL;
> +	datalen = ret;
>  
>  	pc = tcf_hash_check(parm->index, a, bind, &simp_hash_info);
>  	if (!pc) {

This clobbers 'ret' which is compared to ACT_P_CREATED
later in the function.  If the !pc branch below this code
is not taken, ret must be left at it's initial value of
zero.  Now, it will take on some non-zero positive value
which is not correct.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ