[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <4806C501.20300@tiscali.nl>
Date: Thu, 17 Apr 2008 05:33:21 +0200
From: Roel Kluin <12o3l@...cali.nl>
To: hadi@...erus.ca, netdev@...r.kernel.org,
lkml <linux-kernel@...r.kernel.org>
Subject: [PATCH] NET: catch signed nla_len() retval in tcf_simp_init()
'datalen' is unsigned, use 'ret' instead to catch a negative return value.
Signed-off-by: Roel Kluin <12o3l@...cali.nl>
---
diff --git a/net/sched/act_simple.c b/net/sched/act_simple.c
index fbde461..b78d015 100644
--- a/net/sched/act_simple.c
+++ b/net/sched/act_simple.c
@@ -114,9 +114,10 @@ static int tcf_simp_init(struct nlattr *nla, struct nlattr *est,
if (defdata == NULL)
return -EINVAL;
- datalen = nla_len(tb[TCA_DEF_DATA]);
- if (datalen <= 0)
+ ret = nla_len(tb[TCA_DEF_DATA]);
+ if (ret <= 0)
return -EINVAL;
+ datalen = ret;
pc = tcf_hash_check(parm->index, a, bind, &simp_hash_info);
if (!pc) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists